Remove vue/cli as dependency and add missing polyfills
#957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #957 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 62 62
Lines 3928 3928
=======================================
Hits 2686 2686
Misses 1242 1242 |
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/remove-vue-cli
|
| Run status |
|
| Run duration | 06m 15s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
396
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
changed the title
vue/cli as dependency and add missing polyfills
ml-evs
added
build
This was referenced Oct 22, 2024
BenjaminCharmes
approved these changes
Oct 23, 2024
ml-evs
force-pushed
the
ml-evs/remove-vue-cli
branch
from
e642702 to
d9b02a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vue/cliis not needed after the initial project scaffold, but as it is in maintenance mode, it leads to many dependency security issues for us. This PR removes it entirely from the repo, along with all of the extra deps it brings.Note, this is different from the
vue/cli-service, which is also deprecated, but simply provides some wrapper scripts for e.g., cypress, eslint, build, serve etc.Because Javascript, removing vue/cli also breaks a load of webpack 5 polyfills, because vue/cli was already polyfilling the update from webpack 4 to 5 for us magically. So I've had to add those back in explicitly, with
processandbuffer