Add e2e JS tests for file upload and block creation #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ml-evs
force-pushed
the
ml-evs/edit-page-plus-bens-fix
branch
2 times, most recently
from
514a175 to
333b146
Compare
- Skip name check - Fix test typo
ml-evs
force-pushed
the
ml-evs/edit-page-plus-bens-fix
branch
from
333b146 to
fd8747d
Compare
ml-evs
changed the title
ml-evs
commented
Oct 24, 2024
ml-evs
added
testing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #968 +/- ##
=======================================
Coverage 68.38% 68.38%
=======================================
Files 62 62
Lines 3928 3928
=======================================
Hits 2686 2686
Misses 1242 1242 |
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
ml-evs/edit-page-plus-bens-fix
|
| Run status |
|
| Run duration | 06m 43s |
| Commit |
|
| Committer | Matthew Evans |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
402
|
| View all changes introduced in this branch ↗︎ | |
ml-evs
force-pushed
the
ml-evs/edit-page-plus-bens-fix
branch
from
fd8747d to
794224a
Compare
|
✔️ Thanks for this @BenjaminCharmes! We could think about expanding the test case slightly to properly check that bokeh is working (e.g., check that something happens if you change axis/wavelength), but this is great for now. |
ml-evs
changed the title
- Small fix for e2e test - Fix example_data path for e2e test - Tweak test cases for XRD plot
ml-evs
force-pushed
the
ml-evs/edit-page-plus-bens-fix
branch
from
794224a to
675906d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extracts just the tests from #938 before the refactor in #943.