Add an :s one-or-more whitespace matcher
#110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
reviewed
Jun 30, 2019
|
|
||
| [Matcher("s")] | ||
| public static TextParser<object> WhiteSpace { get; } = | ||
| Span.WithAll(ch => ch == ' ' || ch == '\t') |
There was a problem hiding this comment.
Would you expect this to match carriage returns and linefeeds too?
There was a problem hiding this comment.
Many of the other patterns are linefeed-aware, so slurping them up can have unexpected consequences.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been omitted so far because either
{:*}is suitable for this in almost all cases. Looking for and thinking in terms of{:s}is natural, however, and there doesn't seem to be any harm in including it.README updated with current matchers.