Fix up unused level property #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
commented
Jan 5, 2024
| @@ -35,7 +35,7 @@ public static LogEvent FromProperties(IDictionary<string, object?> properties, s | |||
| var messageTemplate = GetMessageTemplate(properties); | |||
| var traceId = GetTraceId(properties); | |||
| var spanId = GetSpanId(properties); | |||
| var props = GetLogEventProperties(properties, remainder, level); | |||
| var props = GetLogEventProperties(properties, remainder); | |||
There was a problem hiding this comment.
This level is no longer needed; it would tack the surrogate level property on, but we do this while reading now.
nblumhardt
approved these changes
Jan 5, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #302 we refactored a lot of how events are constructed. One existing piece of functionality that was lost was being able to specify a level to override any in the events with when ingesting. This PR restores that functionality.