Add tracing to seqcli sample ingest #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
reviewed
Jan 23, 2024
| <ItemGroup> | ||
| <PackageReference Include="Serilog" Version="3.1.1" /> | ||
| <PackageReference Include="SerilogTracing" Version="1.0.0-dev-00088" /> |
There was a problem hiding this comment.
The prerelease dependency may be a problem here, we're not expecting SerilogTracing to RTM ahead of this, and having a prerelease dependency will block our .NET tool package publishing.
|
Any chance of a screenshot with this one? :-) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
seqcli sample ingestproduce spans instead of manually measuring the time operations take. The spans produced are fairly simplistic, but provide enough context to demonstrate various features, and highlight the kinds of issues that tracing is good at surfacing.