Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global_architectures.py #501

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Update global_architectures.py #501

merged 3 commits into from
Feb 16, 2024

Conversation

DomInvivo
Copy link
Collaborator

Removed double check of embed_dim/num_heads, discussed in PR #494

Changelogs

  • enumerate the changes of that PR.

Checklist:

  • Was this PR discussed in an issue? It is recommended to first discuss a new feature into a GitHub issue before opening a PR.
  • Add tests to cover the fixed bug(s) or the new introduced feature(s) (if appropriate).
  • Update the API documentation is a new function is added, or an existing one is deleted.
  • Write concise and explanatory changelogs above.
  • If possible, assign one of the following labels to the PR: feature, fix or test (or ask a maintainer to do it for you).

discussion related to that PR

Removed double check of embed_dim/num_heads, discussed in PR #494
Copy link

codecov bot commented Dec 24, 2023

Codecov Report

Merging #501 (0e6c932) into main (f698df4) will decrease coverage by 1.77%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   71.52%   69.76%   -1.77%     
==========================================
  Files          93       93              
  Lines        8707     8705       -2     
==========================================
- Hits         6228     6073     -155     
- Misses       2479     2632     +153     
Flag Coverage Δ
unittests 69.76% <ø> (-1.77%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
ipu 29.75% <ø> (-19.40%) ⬇️

@DomInvivo DomInvivo merged commit 48d26fd into main Feb 16, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant