-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Solve cross-platform import problem on MacOS build #910
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Stuart Preston <mail@stuartpreston.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was my first thought also but unfortunately, we must have postimport.ps1 run for the module to work at all, as it sets all the defaults and the configurations
|
You are right and I can't read :-) |
Yes I have to fix some paths on those other functions |
@stuartpreston I have updated a few other files as well |
and I have added the PR workflow so that it will run the tests too :-) |
Convert-Path shouldn't be required to support PowerShell on Mac or Linux. |
Fixes #909
This change might solve the problem with the MacOS build.
Note: Unfortunately I encountered further errors in the build on my local machine to do with the New-Json function either not correctly establishing the path to the test repo I'm likely missing a dependency since Get-CheckRepo isn't available on my machine so submitting this PR first to see if it gets us any further.