Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Solve cross-platform import problem on MacOS build #910

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

stuartpreston
Copy link

@stuartpreston stuartpreston commented Jan 2, 2023

Fixes #909

This change might solve the problem with the MacOS build.

Note: Unfortunately I encountered further errors in the build on my local machine to do with the New-Json function either not correctly establishing the path to the test repo I'm likely missing a dependency since Get-CheckRepo isn't available on my machine so submitting this PR first to see if it gets us any further.

Signed-off-by: Stuart Preston <mail@stuartpreston.net>
@SQLDBAWithABeard SQLDBAWithABeard self-assigned this Jan 2, 2023
@SQLDBAWithABeard SQLDBAWithABeard self-requested a review January 2, 2023 18:01
Copy link
Collaborator

@SQLDBAWithABeard SQLDBAWithABeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my first thought also but unfortunately, we must have postimport.ps1 run for the module to work at all, as it sets all the defaults and the configurations

@stuartpreston
Copy link
Author

postimport.ps1 is still being run, I just took out the Linux specialism and converted the paths so it should import on all 3 platforms. I think there's then problems with the New-Json function but that's a bit after this import problem.

@SQLDBAWithABeard
Copy link
Collaborator

SQLDBAWithABeard commented Jan 2, 2023

You are right and I can't read :-)
I have no idea what I saw - Apologies

@SQLDBAWithABeard
Copy link
Collaborator

Yes I have to fix some paths on those other functions

@SQLDBAWithABeard
Copy link
Collaborator

@stuartpreston I have updated a few other files as well
Thank you very much for the prompt
Its odd that only these files were the ones that fell over publicly
May you test this please to see if it imports

@SQLDBAWithABeard
Copy link
Collaborator

and I have added the PR workflow so that it will run the tests too :-)

@SQLDBAWithABeard SQLDBAWithABeard dismissed their stale review January 2, 2023 21:22

because I cant read

@SQLDBAWithABeard SQLDBAWithABeard mentioned this pull request Jan 3, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

MacOs Test Results

       1 files  548 suites   28s ⏱️
   466 tests 128 ✔️ 0 💤    338
1 815 runs  128 ✔️ 0 💤 1 687

For more details on these failures, see this check.

Results for commit cd3f4c2.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

Linux Test Results

       1 files  548 suites   30s ⏱️
   466 tests 128 ✔️ 0 💤    338
1 815 runs  128 ✔️ 0 💤 1 687

For more details on these failures, see this check.

Results for commit cd3f4c2.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

WinPS51 Test Results

       1 files  548 suites   25s ⏱️
   466 tests 128 ✔️ 0 💤    338
1 815 runs  128 ✔️ 0 💤 1 687

For more details on these failures, see this check.

Results for commit cd3f4c2.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2023

WinPS71 Test Results

       1 files  548 suites   27s ⏱️
   466 tests 128 ✔️ 0 💤    338
1 815 runs  128 ✔️ 0 💤 1 687

For more details on these failures, see this check.

Results for commit cd3f4c2.

@wsmelton
Copy link
Member

wsmelton commented Jan 3, 2023

Convert-Path shouldn't be required to support PowerShell on Mac or Linux.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Doesnt import on MacOS
3 participants