turns out the scoping was right all along

dataplat · Oct 26, 2024 · addd41f · addd41f
1 parent ffddf03
commit addd41f
Show file tree

Hide file tree

Showing 29 changed files with 88 additions and 88 deletions.
diff --git a/.aider/prompts/conventions.md b/.aider/prompts/conventions.md
@@ -129,8 +129,8 @@ Describe "Get-DbaDatabase" -Tag "UnitTests" {
    Context "Parameter validation" {
        BeforeAll {
            $command = Get-Command Get-DbaDatabase
-           $script:expected = $TestConfig.CommonParameters
-           $script:expected += @(
+           $expected = $TestConfig.CommonParameters
+           $expected += @(
                "SqlInstance",
                "SqlCredential",
                "Database",
@@ -143,7 +143,7 @@ Describe "Get-DbaDatabase" -Tag "UnitTests" {
            $command | Should -HaveParameter $PSItem
        }
 
-       It "Should have exactly the number of expected parameters" {
+       It "Should have exactly the number of expected parameters ($($expected.Count))" {
            $hasparms = $command.Parameters.Values.Name
            Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
        }

diff --git a/tests/Add-DbaAgDatabase.Tests.ps1 b/tests/Add-DbaAgDatabase.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaAgDatabase" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaAgDatabase
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "AvailabilityGroup",
@@ -31,7 +31,7 @@ Describe "Add-DbaAgDatabase" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaAgListener.Tests.ps1 b/tests/Add-DbaAgListener.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaAgListener" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaAgListener
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "AvailabilityGroup",
@@ -31,7 +31,7 @@ Describe "Add-DbaAgListener" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaAgReplica.Tests.ps1 b/tests/Add-DbaAgReplica.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaAgReplica" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaAgReplica
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "Name",
@@ -39,7 +39,7 @@ Describe "Add-DbaAgReplica" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaComputerCertificate.Tests.ps1 b/tests/Add-DbaComputerCertificate.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaComputerCertificate" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaComputerCertificate
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "ComputerName",
                 "Credential",
                 "SecurePassword",
@@ -28,7 +28,7 @@ Describe "Add-DbaComputerCertificate" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaDbMirrorMonitor.Tests.ps1 b/tests/Add-DbaDbMirrorMonitor.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaDbMirrorMonitor" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaDbMirrorMonitor
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "EnableException",
@@ -22,7 +22,7 @@ Describe "Add-DbaDbMirrorMonitor" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaDbRoleMember.Tests.ps1 b/tests/Add-DbaDbRoleMember.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaDbRoleMember" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaDbRoleMember
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "Database",
@@ -26,7 +26,7 @@ Describe "Add-DbaDbRoleMember" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaExtendedProperty.Tests.ps1 b/tests/Add-DbaExtendedProperty.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaExtendedProperty" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaExtendedProperty
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "Database",
@@ -26,7 +26,7 @@ Describe "Add-DbaExtendedProperty" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaPfDataCollectorCounter.Tests.ps1 b/tests/Add-DbaPfDataCollectorCounter.Tests.ps1
@@ -3,12 +3,13 @@ param(
     $ModuleName = "dbatools",
     $PSDefaultParameterValues = ($TestConfig = Get-TestConfig).Defaults
 )
+
 Describe "Add-DbaPfDataCollectorCounter" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaPfDataCollectorCounter
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "ComputerName",
                 "Credential",
                 "CollectorSet",
@@ -25,8 +26,7 @@ Describe "Add-DbaPfDataCollectorCounter" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
-            $expected.count | Write-Warning
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaRegServer.Tests.ps1 b/tests/Add-DbaRegServer.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaRegServer" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaRegServer
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "ServerName",
@@ -32,7 +32,7 @@ Describe "Add-DbaRegServer" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaRegServerGroup.Tests.ps1 b/tests/Add-DbaRegServerGroup.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaRegServerGroup" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaRegServerGroup
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "Name",
@@ -26,7 +26,7 @@ Describe "Add-DbaRegServerGroup" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaReplArticle.Tests.ps1 b/tests/Add-DbaReplArticle.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaReplArticle" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaReplArticle
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "Database",
@@ -28,7 +28,7 @@ Describe "Add-DbaReplArticle" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Add-DbaServerRoleMember.Tests.ps1 b/tests/Add-DbaServerRoleMember.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Add-DbaServerRoleMember" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Add-DbaServerRoleMember
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "ServerRole",
@@ -26,7 +26,7 @@ Describe "Add-DbaServerRoleMember" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Backup-DbaComputerCertificate.Tests.ps1 b/tests/Backup-DbaComputerCertificate.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Backup-DbaComputerCertificate" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Backup-DbaComputerCertificate
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SecurePassword",
                 "InputObject",
                 "Path",
@@ -23,7 +23,7 @@ Describe "Backup-DbaComputerCertificate" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Backup-DbaDbCertificate.Tests.ps1 b/tests/Backup-DbaDbCertificate.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Backup-DbaDbCertificate" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Backup-DbaDbCertificate
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "Certificate",
@@ -30,7 +30,7 @@ Describe "Backup-DbaDbCertificate" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Backup-DbaDbMasterKey.Tests.ps1 b/tests/Backup-DbaDbMasterKey.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Backup-DbaDbMasterKey" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Backup-DbaDbMasterKey
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "Credential",
@@ -28,7 +28,7 @@ Describe "Backup-DbaDbMasterKey" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Backup-DbaServiceMasterKey.Tests.ps1 b/tests/Backup-DbaServiceMasterKey.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Backup-DbaServiceMasterKey" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Backup-DbaServiceMasterKey
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "KeyCredential",
@@ -25,7 +25,7 @@ Describe "Backup-DbaServiceMasterKey" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Clear-DbaConnectionPool.Tests.ps1 b/tests/Clear-DbaConnectionPool.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Clear-DbaConnectionPool" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Clear-DbaConnectionPool
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "ComputerName",
                 "Credential",
                 "EnableException"
@@ -20,7 +20,7 @@ Describe "Clear-DbaConnectionPool" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }

diff --git a/tests/Clear-DbaLatchStatistics.Tests.ps1 b/tests/Clear-DbaLatchStatistics.Tests.ps1
@@ -8,8 +8,8 @@ Describe "Clear-DbaLatchStatistics" -Tag "UnitTests" {
     Context "Parameter validation" {
         BeforeAll {
             $command = Get-Command Clear-DbaLatchStatistics
-            $script:expected = $TestConfig.CommonParameters
-            $script:expected += @(
+            $expected = $TestConfig.CommonParameters
+            $expected += @(
                 "SqlInstance",
                 "SqlCredential",
                 "EnableException",
@@ -22,7 +22,7 @@ Describe "Clear-DbaLatchStatistics" -Tag "UnitTests" {
             $command | Should -HaveParameter $PSItem
         }
 
-        It "Should have exactly the number of expected parameters" {
+        It "Should have exactly the number of expected parameters ($($expected.Count))" {
             $hasparms = $command.Parameters.Values.Name
             Compare-Object -ReferenceObject $expected -DifferenceObject $hasparms | Should -BeNullOrEmpty
         }