Find-DbaInstance - Fix regex for UDP Search (#9072)

dataplat · Sep 21, 2023 · c984b2e · c984b2e
1 parent 7f5e149
commit c984b2e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/public/Find-DbaInstance.ps1 b/public/Find-DbaInstance.ps1
@@ -727,7 +727,7 @@ function Find-DbaInstance {
                         #endregion Connect to browser service and receive response
 
                         #region Parse Output
-                        $Response | Select-String "(ServerName;(\w+);InstanceName;(\w+);IsClustered;(\w+);Version;(\d+\.\d+\.\d+\.\d+);(tcp;(\d+)){0,1})" -AllMatches | Select-Object -ExpandProperty Matches | ForEach-Object {
+                        $Response | Select-String "(ServerName;([a-zA-Z0-9_-]+);InstanceName;(\w+);IsClustered;(\w+);Version;(\d+\.\d+\.\d+\.\d+);(tcp;(\d+)){0,1})" -AllMatches | Select-Object -ExpandProperty Matches | ForEach-Object {
                             $obj = New-Object Dataplat.Dbatools.Discovery.DbaBrowserReply -Property @{
                                 MachineName  = $computer.ComputerName
                                 ComputerName = $_.Groups[2].Value
@@ -1083,4 +1083,4 @@ function Find-DbaInstance {
         }
         $steppablePipeline.End()
     }
-}
+}
diff --git a/tests/Find-DbaInstance.Tests.ps1 b/tests/Find-DbaInstance.Tests.ps1
@@ -24,9 +24,9 @@ Describe "$CommandName Integration Tests" -Tag "IntegrationTests" {
     Context "Command finds SQL Server instances" {
         BeforeAll {
             if ($env:APPVEYOR) {
-                $results = Find-DbaInstance -ComputerName $script:instance3 -ScanType Browser, SqlConnect
+                $results = Find-DbaInstance -ComputerName $script:instance3 -ScanType Browser, SqlConnect | Select-Object -First 1
             } else {
-                $results = Find-DbaInstance -ComputerName $TestServer -ScanType Browser, SqlConnect
+                $results = Find-DbaInstance -ComputerName $TestServer -ScanType Browser, SqlConnect | Select-Object -First 1
             }
         }
         It "Returns an object type of [Dataplat.Dbatools.Discovery.DbaInstanceReport]" {
@@ -42,4 +42,4 @@ Describe "$CommandName Integration Tests" -Tag "IntegrationTests" {
             $results.SqlConnected | Should -Be $true
         }
     }
-}
+}