Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed server issue in command New-DbaAgentJobStep #4714

Merged
merged 2 commits into from
Nov 29, 2018

Conversation

sanderstad
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • Nunit test is included
  • Documentation
  • Build system

Purpose

The server property was missing which was needed for several subsystems.

Approach

A new parameter is added called "SubsystemServer" which needs to be used when a particular subsytem is chosen.

Commands to test

New-DbaAgentJobStep -SqlInstance . -Database [db] -Job [jobname]-StepName [stepname] -OnSuccessAction 'GoToNextStep' -OnFailAction 'QuitWithFailure' -Subsystem AnalysisCommand -SubsystemServer [server] -Command "Test"

Screenshots

image

@potatoqualitee
Copy link
Member

fixed formatting, all other tests pass

@potatoqualitee potatoqualitee merged commit 50ac947 into development Nov 29, 2018
@potatoqualitee potatoqualitee deleted the fix-jobstep-command branch November 29, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants