Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Masking enhancements #5388

Merged
merged 21 commits into from
Apr 25, 2019
Merged

Masking enhancements #5388

merged 21 commits into from
Apr 25, 2019

Conversation

sanderstad
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Added composite functionality to masking commands
Made preparations to do config check using a json schema

Approach

Added functionality to compose the value of a column using columns, static values and/or dynamically generated values

Commands to test

New-DbaDbDataMaskingConfig
Invoke-DbaDbDataMasking

@potatoqualitee
Copy link
Member

always enjoy these 💯

@potatoqualitee
Copy link
Member

unfortunately there are failures on your specific tests, @sanderstad

Commented out length check
Separated different date types
Moved code around
Changed the min and max value settings for dates
@sanderstad sanderstad self-assigned this Apr 25, 2019
@potatoqualitee potatoqualitee merged commit 2819986 into development Apr 25, 2019
@potatoqualitee potatoqualitee deleted the masking-enhancements branch April 25, 2019 09:42
@potatoqualitee
Copy link
Member

boooooom!

@potatoqualitee
Copy link
Member

will release in a bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants