Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Add-DbaRegServerGroup #5752

Merged
merged 2 commits into from
Jun 17, 2019
Merged

Improve Add-DbaRegServerGroup #5752

merged 2 commits into from
Jun 17, 2019

Conversation

ClaudioESSilva
Copy link
Collaborator

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

Improve the way to handle with existing groups.

Approach

Commands to test

Screenshots

Before:
image

After:
image

Learning

@potatoqualitee
Copy link
Member

this is bomb! thanks for the extra tests too!

@potatoqualitee potatoqualitee merged commit 126a66a into prerelease Jun 17, 2019
@potatoqualitee potatoqualitee deleted the Improve_Add-DbaRegServerGroup branch June 17, 2019 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@potatoqualitee potatoqualitee Awaiting requested review from potatoqualitee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClaudioESSilva @potatoqualitee