Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Secondary Log Shipping Monitor #5764

Merged
merged 3 commits into from
Jun 17, 2019
Merged

Conversation

sanderstad
Copy link
Contributor

Type of Change

  • Bug fix (non-breaking change, fixes #)
  • New feature (non-breaking change, adds functionality)
  • Breaking change (effects multiple commands or functionality)
  • Ran manual Pester test and has passed (`.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/sqlcollaborative/appveyor-lab ?
  • Nunit test is included
  • Documentation
  • Build system

Purpose

When you assign a secondary monitor server, the command would not use that monitor server although it was set.

Approach

Somewhere along the way variables for the primary server were passed along to the internal log shipping command that also makes the changes for the secondary monitor.

Commands to test

Invoke-DbaDbLogShipping

Screenshots

I used two different values because I did not have enough resources to test this on two different instances.
I used "localhost" for the primary and my local hostname (IT-SStad-Mobile) as the secondary. Technically they're the same but the values should be represented differently

The right secondary server is used
image

The right secondary monitor server is passed
image

@potatoqualitee
Copy link
Member

this is gorgeous! thank you 🙇

@potatoqualitee potatoqualitee merged commit c4599f2 into prerelease Jun 17, 2019
@potatoqualitee potatoqualitee deleted the fix-logshippingmonitor branch June 17, 2019 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants