Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy-DbaDatabase - Use correct variable for testing for same database #9032

Merged
merged 5 commits into from
Sep 21, 2023

Conversation

andreasjordan
Copy link
Contributor

@andreasjordan andreasjordan commented Jul 11, 2023

Please read -- recent changes to our repo

On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.

PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.

  • Please confirm you have the smaller repo (85MB .git directory vs 275MB or 110MB or 185MB .git directory)

Type of Change

  • Bug fix (non-breaking change, fixes Copy-DbaDatabase incorrectly reports that source and destination databases are the same when using -Force #9031 )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

See issue for details.

Fix is change in line 1113, other changes just correct casing.

@wsmelton
Copy link
Member

Throwing in commenting out the GH Azure tests to see if this PR can get green check before merging.

@potatoqualitee
Copy link
Member

Passed!

@potatoqualitee potatoqualitee merged commit 25d6d0a into development Sep 21, 2023
9 checks passed
@potatoqualitee potatoqualitee deleted the CopyDbaDatabase_fix_9031 branch September 21, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Copy-DbaDatabase incorrectly reports that source and destination databases are the same when using -Force
3 participants