Bug Fix #9068. New-DbaDbUser #9078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test is failing for adding users to multiple databases: 
|
|
Thanks, @wsmelton. My office network blocks downloading anything from GitHub. Couldn't check this when I'm in office. I added a new test to cover this scenario. Looks like the test server has more database than the ones created for this testing. I will modify the test so that it matches with the total number of user databases in the test server. |
|
@wsmelton Fixed the tests, its looking good now. Can you please review? |
|
Can this PR get reviewed please? |
|
yes, our apologies, @sqlarticles. We had code signing issues that preventing merging/releasing. Tests pass, your code looks good and we very much appreciate the PR 👍🏼 💯 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please read -- recent changes to our repo
On November 10, 2022, we removed some bloat from our repository (for the second and final time). This change requires that all contributors reclone or refork their repo.
PRs from repos that have not been recently reforked or recloned will be closed and @potatoqualitee will cherry-pick your commits and open a new PR with your changes.
Type of Change
.\tests\manual.pester.ps1)Purpose
Approach
Bug fix #9068
New-DbaDbUserfunction failed to create the user in all the user databases whenDatabaseparameter is not provided. Changes are made to fix this, when theDatabaseparameter is not provided then the user will be created in all the user databases.Commands to test
New-DbaDbUser -SqlInstance Server1 -Login User1Screenshots
Learning