Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test-DbaDbRecoveryModel: Fix for instances with case sensitive collation #9425

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

michele-tahay-kohera
Copy link
Contributor

I was getting the following results on a system with a case sensitive collation (Latin1_General_100_CS_AS)

WARNING: [19:42:15][Test-DbaDbRecoveryModel] Error occurred while establishing connection to xxxxxxxxxx | The multi-part identifier "d.recovery_model" could not be bound. The multi-part identifier "d.name" could not be bound. The multi-part identifier "d.recovery_model" could not be bound. The multi-part identifier "d.recovery_model_desc" could not be bound. The multi-part identifier "d.recovery_model" could not be bound.

Type of Change

  • Bug fix (non-breaking change, fixes # )
  • New feature (non-breaking change, adds functionality, fixes # )
  • Breaking change (affects multiple commands or functionality, fixes # )
  • Ran manual Pester test and has passed (.\tests\manual.pester.ps1)
  • Adding code coverage to existing functionality
  • Pester test is included
  • If new file reference added for test, has is been added to github.com/dataplat/appveyor-lab ?
  • Unit test is included
  • Documentation
  • Build system

Purpose

Be able to use dbacheck "PseudoSimple" that uses this dbatool function

Approach

Using the same casing for the table alias will resolve any casing issues with case sensitive collations.L

I was getting the following results on a system with a case sensitive collation

WARNING: [19:42:15][Test-DbaDbRecoveryModel] Error occurred while establishing connection to xxxxxxxxxx | The
multi-part identifier "d.recovery_model" could not be bound.
The multi-part identifier "d.name" could not be bound.
The multi-part identifier "d.recovery_model" could not be bound.
The multi-part identifier "d.recovery_model_desc" could not be bound.
The multi-part identifier "d.recovery_model" could not be bound.
@andreasjordan andreasjordan changed the title small bugfix for Test-DbaDbRecoveryModel for instances with case sensitive collation Test-DbaDbRecoveryModel: Fix for instances with case sensitive collation Jul 20, 2024
Copy link
Contributor

@andreasjordan andreasjordan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request, changes look good to me.

@potatoqualitee potatoqualitee merged commit c7df5a9 into dataplat:development Jul 21, 2024
3 checks passed
@potatoqualitee
Copy link
Member

Thank you very much! And welcome 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants