Refactor AgHadr tests #9498
Merged
Refactor AgHadr tests #9498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test for @niphlod Can you help here? |
|
Ok, solved the problem... |
|
thank you 🙇🏼 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR only changes tests and no code of the module itself.
Currently
$script:instance3is used for Availability Group tests and needs Hadr service setting enabled. This is done for AppVeyor in appveyor.SQL2027.ps1 with$null = Enable-DbaAgHadr -SqlInstance $sqlinstance -Confirm:$false -Force.So every test can assume that the instance is configured correctly and has to end the test with a correctly configured instance.
Currently we don't see problems in AppVeyor because Disable-DbaAgHadr.Tests.ps1 is run as last test. But to be able to test locally we need to fix this.