Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests for Availability Groups #9500

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

andreasjordan
Copy link
Contributor

@andreasjordan andreasjordan commented Oct 11, 2024

This PR only changes tests and no code of the module itself.

The certificate "dbatoolsci_AGCert" is part of the test environment and must not be created. This is done for AppVeyor in appveyor.SQL2027.ps1 with $server.Query("CREATE CERTIFICATE dbatoolsci_AGCert WITH SUBJECT = 'AG Certificate'").

The certificate "dbatoolsci_AGCert" is needed in other tests and must not be deleted.

I changed the portnumber of the listener, so I'm able to run the test locally when instance1 is listening on 1433.

@andreasjordan andreasjordan changed the title Fix test for New-DbaAvailabilityGroup Fix tests for Availability Groups Oct 11, 2024
@andreasjordan andreasjordan marked this pull request as ready for review October 11, 2024 19:46
@potatoqualitee
Copy link
Member

Really appreciate these changes!

@potatoqualitee potatoqualitee merged commit e9bef99 into development Oct 14, 2024
13 checks passed
@potatoqualitee potatoqualitee deleted the NewDbaAvailabilityGroup_test_certificate branch October 14, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants