Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Mona Great Again #16

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Make Mona Great Again #16

merged 1 commit into from
Mar 29, 2018

Conversation

bronydell
Copy link
Contributor

@bronydell bronydell commented Mar 23, 2018

Copy link
Member

@dzhlobo dzhlobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bronydell, let's merge it ❤️. Thank you.

@dzhlobo
Copy link
Member

dzhlobo commented Mar 27, 2018

@bronydell, a couple thoughts for future:

  1. It's hard to read and identify changes when you do refactoring in the same pull request. It's better to either do refactoring first and then do logic changes, or vice versa. But not in the same pull requests.
  2. It's better to split pull requests per meaningful changes. Like you fix timezone in one pull request. You fix greetings in another pull request. In that case we can review and merge PRs much faster.

@bronydell bronydell merged commit 5f8b446 into master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants