Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

json output config file #47

Closed
thanasions opened this issue Sep 10, 2018 · 3 comments
Closed

json output config file #47

thanasions opened this issue Sep 10, 2018 · 3 comments
Assignees

Comments

@thanasions
Copy link
Contributor

Json needs to include:

absolute_path_pkl (of pickled file used as input),
absolute_path_tech_report (of tech_report.txt),
cpc
year_from,
year_to,
pick,
time,
cite,
focus

@IanGrimstead
Copy link
Contributor

Created branch 47-json-config

@IanGrimstead
Copy link
Contributor

Use case: -json will trigger output of a .json file alongside the report .txt file in outputs\reports
Report name is same for json (just different file extension)

@thanasions
Copy link
Contributor Author

{
"paths": {
"data": "absolute_path",
"tech_report": "absolute_path"
},
"year": {
"from": "blah",
"to": "blah"
},
"parameters": {
"pick": "blah",
"time": false,
"cite": false,
"focus": false
}
}

thanasions added a commit that referenced this issue Sep 11, 2018
Implemented JSON output and tested via Mocks (#47)
IanGrimstead added a commit that referenced this issue Sep 11, 2018
* data path now absolute in json (fixes #47) and is now tested
IanGrimstead added a commit that referenced this issue Sep 12, 2018
* Renamed fdg folder to visuals, matched source code to new folder #49
Removed unnecessary folder creation in outputs
* Implemented JSON output and tested via Mocks (#47)
IanGrimstead added a commit that referenced this issue Sep 14, 2018
* Renamed fdg folder to visuals, matched source code to new folder #49
* Data path now absolute in json (fixes #47) and is now tested
* Path corrected for empty.json (fixes #56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants