datasette-secrets integration

[simonw]

Refs:

• Use datasette-secrets for API key #9

TODO:

• Manual testing
• Update README to talk about new configuration options with datasette-secrets

[simonw]

Testing manually, first:

export DATASETTE_SECRETS_OPENAI_API_KEY=$(cat "$(llm keys path)" | jq .openai -r)

Then:

datasette museums.db --root -p 8045 --secret 1

That ran an enrichment fine.

Then I ran this, such that it would show me a field to enter the key:

export DATASETTE_SECRETS_OPENAI_API_KEY=''

... and got the weirdest bug, it segfaulted when I submitted the form with the secret is!

INFO:     127.0.0.1:56557 - "POST /-/enrich/museums/museums/gpt?_search=hearst HTTP/1.1" 302 Found
zsh: segmentation fault  datasette museums.db --root -p 8045 --secret 1

It's repeatable, I've seen it do that twice now.

[simonw]

I think I may have left some breakpoint() calls in there! https://github.com/datasette/datasette-enrichments/blob/67708b6e063f374778df85bca2972f8ef6717778/datasette_enrichments/__init__.py#L115-L133

[simonw]

After that fix my manual test of what happens if you enter an API key as part of the form itself passed.

[simonw]

This now has a test as well thanks to:

• Automated tests #12

[simonw]

This now has a test as well thanks to:

• Automated tests #12