Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better extract to table support, image support #11

Merged
merged 10 commits into from
Mar 7, 2024
Merged

Conversation

simonw
Copy link
Collaborator

@simonw simonw commented Mar 7, 2024

Needs tests and docs before landing.

@simonw simonw changed the title Better table support Better extract to table support, image support Mar 7, 2024
@simonw
Copy link
Collaborator Author

simonw commented Mar 7, 2024

Error 500
no such table: _datasette_extract

Because it may not have been created the first time you view the/db/table/-/extract page.

@simonw simonw closed this Mar 7, 2024
@simonw simonw reopened this Mar 7, 2024
@simonw
Copy link
Collaborator Author

simonw commented Mar 7, 2024

I used download-esm to grab the PDF library, though I had to download the worker file separately.

@simonw
Copy link
Collaborator Author

simonw commented Mar 7, 2024

This is missing tests but I'm going to land it and ship it as an alpha anyway.

@simonw simonw merged commit 5fefcf6 into main Mar 7, 2024
8 checks passed
simonw added a commit that referenced this pull request Mar 7, 2024
@simonw simonw deleted the better-table-support branch March 7, 2024 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant