Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues/104 Fix paging logic in search result handling of resource provider #105

Merged
merged 1 commit into from
Oct 2, 2023
Merged

Issues/104 Fix paging logic in search result handling of resource provider #105

merged 1 commit into from
Oct 2, 2023

Conversation

EmteZogaf
Copy link
Collaborator

  • Prevent infinite requests of next result pages under certain conditions when searching for joined resources using search parameter _included
  • Add unit test cases for class OrganizationProviderImpl

Closes #104

@EmteZogaf EmteZogaf force-pushed the issues/104_Search_for_organizations_by_parent_organization_and_member_role_hangs_in_infinite_loop branch from cf72bc5 to ec1faec Compare September 18, 2023 19:05
@EmteZogaf
Fix paging logic in search result handling of resource provider
4fac832 
The results of a FHIR search query using search entry mode 'included'
could lead to infinite number of requests of incrementing result page
number if the number of resources of the join (with search mode
'included') in the results is less than the number of the primary
resources (with search mode 'match').
This fix only requests the next result page if the previous result
bundle contains a 'next' link.

Add test cases for OrganizationProviderImpl.
@EmteZogaf EmteZogaf force-pushed the issues/104_Search_for_organizations_by_parent_organization_and_member_role_hangs_in_infinite_loop branch from ec1faec to 4fac832 Compare September 18, 2023 19:33
@hhund hhund added this to the 1.3.0 milestone Oct 2, 2023
@hhund hhund self-assigned this Oct 2, 2023
@hhund hhund linked an issue Oct 2, 2023 that may be closed by this pull request
Search for organizations by parent organization and member role hangs in infinite loop #104
Closed
@hhund hhund merged commit 390003b into datasharingframework:develop Oct 2, 2023
1 check passed
@EmteZogaf EmteZogaf deleted the issues/104_Search_for_organizations_by_parent_organization_and_member_role_hangs_in_infinite_loop branch October 9, 2023 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hhund hhund

Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.

Search for organizations by parent organization and member role hangs in infinite loop
2 participants
@EmteZogaf @hhund