Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues/124 125 OIDC support #126

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Issues/124 125 OIDC support #126

merged 4 commits into from
Oct 30, 2023

Conversation

hhund
Copy link
Member

@hhund hhund commented Oct 30, 2023

  • Adds the X-Forwarded-Proto header for proxy request to the fhir app server.
  • Only sends the X-ClientCert header if the variable SSL_CLIENT_CERT is not empty. The value is empty if a users is not authenticated with a client certificate and client certificate authentication is optional.
  • Adds mail address based on the iss (issuer) and sub (subject) values from the access token to the currently logged in Practitioner object.

fixes #124
closes #125

With this modification the X-ClientCert header is only set for proxy
requests to the fhir app server if the user is authenticated with a
client certificate and thus the SSL_CLIENT_CERT variable is not empty.
A generated mail address based on the domain in the iss (issuer) value
and the sub (subject) value of the access token is now added to the
current Practitioner object.
@hhund hhund added this to the 1.3.1 milestone Oct 30, 2023
@hhund hhund requested a review from wetret October 30, 2023 15:33
@hhund hhund self-assigned this Oct 30, 2023
@hhund hhund merged commit 3f56f2d into develop Oct 30, 2023
2 checks passed
@hhund hhund deleted the issues/124_125_oidc_support branch December 18, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve some logging for OIDC logins redirect uri for OIDC login is http
2 participants