Removed deprecated secret-namespace references from examples (#380)

* Removing secret-namespace ref from example-dataset-s3-secrets.yaml Signed-off-by: Ryan Borstelmann <ryan@ryanb.tv> * Removing secret-namespace ref from example-dataset-s3-provision.yaml Signed-off-by: Ryan Borstelmann <ryan@ryanb.tv> --------- Signed-off-by: Ryan Borstelmann <ryan@ryanb.tv>
datashim-io · Oct 3, 2024 · 075b8d6 · 075b8d6
1 parent 22dbf24
commit 075b8d6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/examples/templates/example-dataset-s3-provision.yaml b/examples/templates/example-dataset-s3-provision.yaml
@@ -5,10 +5,9 @@ metadata:
 spec:
   local:
     type: "COS"
-    secret-name: "{SECRET_NAME}" #see s3-secrets.yaml for an example
-    secret-namespace: "{SECRET_NAMESPACE}" #optional if the secret is in the same ns as dataset
+    secret-name: "{SECRET_NAME}" #see s3-secrets.yaml for an example. Must be in the same namespace.
     endpoint: "{S3_SERVICE_URL}"
     bucket: "{BUCKET_NAME}"
     readonly: "true" # default is false
     provision: "true" # DLF will allocate bucket on the COS if it doesn't exist [Default: false]
-    region: "" #it can be empty
+    region: "" #it can be empty
diff --git a/examples/templates/example-dataset-s3-secrets.yaml b/examples/templates/example-dataset-s3-secrets.yaml
@@ -5,8 +5,7 @@ metadata:
 spec:
   local:
     type: "COS"
-    secret-name: "{SECRET_NAME}" #see s3-secrets.yaml for an example
-    secret-namespace: "{SECRET_NAMESPACE}" #optional if the secret is in the same ns as dataset
+    secret-name: "{SECRET_NAME}" #see s3-secrets.yaml for an example. Must be in the same namespace.
     endpoint: "{S3_SERVICE_URL}"
     bucket: "{BUCKET_NAME}"
     readonly: "true" # default is false