Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensure S3 buckets are mounted with the right access permissions #292

Merged

Conversation

srikumar003
Copy link
Collaborator

Fixes #269

Ensures that readonly: true in Dataset specification is carried through to the mounting of buckets inside the container

Note: this is tested for csi-s3 backend only. We will need to check other CSI backends to see if the spec is being followed

Signed-off-by: SRIKUMAR VENUGOPAL <srikumarv@ie.ibm.com>
@srikumar003 srikumar003 merged commit 684ea21 into datashim-io:master Aug 1, 2023
2 checks passed
@srikumar003 srikumar003 deleted the 269_fix_readonly_s3_datasets branch August 1, 2023 10:07
@srikumar003 srikumar003 added bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: readonly does not seem to work with s3 Datasets
1 participant