Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the naming convention. #43

Open
4 of 10 tasks
grabear opened this issue Feb 24, 2019 · 1 comment
Open
4 of 10 tasks

Rework the naming convention. #43

grabear opened this issue Feb 24, 2019 · 1 comment

Comments

@grabear
Copy link
Member

grabear commented Feb 24, 2019

So the RenvBuilder class has a bunch of methods and variables with names that make a little sense, but I think we can do better. We've also changed the functionality so, the names could also change based on that. Below I've made lists. The ones checked off are fine to me. Let me know what you think.

Funcitons/classes

  • Renvbuilder
    • self.create
    • self.ensure_directories
    • self.create_configuration
    • self.setup_r
    • self.install_scripts
    • self.format_pkg_list
  • EnvBuilder
    • self.symlink_or_copy (also copier)

Variables

  • context
@grabear
Copy link
Member Author

grabear commented Feb 24, 2019

self.ensure_directories alternatives

  • setup_directories
  • env_init (favorite)

self.create_configuration alternatives

  • env_config
  • configure_env

self.install_scripts alternatives

  • install_templates
  • configure_templates
  • setup_templates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants