Centralize system checks to one method and rework RenvBuilder around this idea.

[grabear]

Instead of making system calls throughout various methods in the class, create a function (utils.get_sys_info or something) that will return system information. Based on a brief scan, this is what RenvBuilder uses in it's logic flow to determine system information, and therefore folder names etct.:

• 

• 

• 

operating system

We are currently working with linux so it would be good to throw an error if os.name returns anything other than posix.

platform

Linux (and Cygwin?) vs Windows vs Mac installs look very different. Throw an error for darwin, and win32 (and cygwin?).

size (32 vs 64 bit platforms)

On Linux machines 32 vs 64 installs look different. Mainly, 32 bit systems use "lib" and 64 bit systems use "lib64". Windows filesystems are much different. I don't know the difference between 32 and 64 bit on windows.

import os
import sys

if os.name == "posix":
    if sys.platform in ["linux", "cygwin"]:
        # do stuff
        # do stuff
        if sys.maxsize > 2**32:
            _lib = "lib64"
        else:
            _lib = "lib"
else: 
    raise OSError

[grabear]

#43

[sdhutchins]

That's perfect. I actually added a catch for that in one of my branches (sys.platform).

[sdhutchins]

Also, perhaps we could consider throwing a Warning instead of an error for mac.

[sdhutchins]

import os
import sys

def check_os():
    if os.name == "posix":
        if sys.platform in ["linux", "cygwin"]:
            if sys.maxsize > 2**32:
                _lib = "lib64"
            else:
                _lib = "lib"
            return _lib
    else: 
        raise OSError

[sdhutchins]

Even less lines:

import os
import sys


def check_os():
    if os.name == "posix":
        if sys.platform in ["linux", "cygwin"] and sys.maxsize == 2**63-1:
            _lib = "lib64"
        elif sys.platform in ["linux", "cygwin"] and sys.maxsize == 2**31-1:
            _lib = "lib"
        return _lib
    else: 
        raise OSError

[grabear]

I like it @sdhutchins. Whenever we get to this, the best thing we can do is think forward...

How can we set up our code so that integrating windows/Mac is easy?
We can help do this with #43 as well.

[santina]

You can also do this: https://kite.com/python/examples/4187/platform-check-if-the-system-is-32-bit-or-64-bit
'
import platform
print platform.architecture()[0] == "32bit"
'
Looks better than hard coding value and have Python calculating 2**63