Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pulsarAdminUrl supplied to Kubernetes runtime to correctly handle plaintext/TLS #176

Conversation

josephglanville
Copy link
Contributor

@josephglanville josephglanville commented Aug 11, 2024

Fixes #175

@josephglanville josephglanville force-pushed the jpg/fix-functions-worker-url-kubernetes-runtime branch from 593d0db to 1a553a0 Compare August 11, 2024 09:36
@dlg99 dlg99 requested a review from nicoloboschi August 13, 2024 18:27
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephglanville
Copy link
Contributor Author

I'm not sure why CI is broken, appears to be breaking on ZK (which is unrelated).

@josephglanville josephglanville force-pushed the jpg/fix-functions-worker-url-kubernetes-runtime branch from d022ebf to 1a553a0 Compare August 14, 2024 16:23
@pgier pgier merged commit f826f8f into datastax:main Aug 14, 2024
12 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants