Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor pom to use Pulsar BOM #5

Merged
merged 4 commits into from
Nov 23, 2022
Merged

Refactor pom to use Pulsar BOM #5

merged 4 commits into from
Nov 23, 2022

Conversation

nicoloboschi
Copy link
Contributor

  • Use import instead of every single dep from LS
  • Upgrade to LS 2.10 2.5

Shaded module diff

< [INFO]    +- org.apache.avro:avro:jar:1.9.0:compile
< [INFO]    +- com.fasterxml.jackson.core:jackson-core:jar:2.13.2:compile
< [INFO]    +- com.fasterxml.jackson.core:jackson-databind:jar:2.13.2.1:compile
< [INFO]    |  \- com.fasterxml.jackson.core:jackson-annotations:jar:2.13.2:compile
---
> [INFO]    +- org.apache.avro:avro:jar:1.10.2:compile
> [INFO]    +- com.fasterxml.jackson.core:jackson-core:jar:2.13.4:compile
> [INFO]    +- com.fasterxml.jackson.core:jackson-databind:jar:2.13.4.2:compile
> [INFO]    |  \- com.fasterxml.jackson.core:jackson-annotations:jar:2.13.4:compile
24c25
< [INFO]    +- com.google.guava:guava:jar:30.1-jre:compile
---
> [INFO]    +- com.google.guava:guava:jar:31.0.1-jre:compile
28c29
< [INFO]    |  +- org.checkerframework:checker-qual:jar:3.5.0:compile
---
> [INFO]    |  +- org.checkerframework:checker-qual:jar:3.12.0:compile
31,32c32
< [INFO]    \- org.slf4j:slf4j-api:jar:1.7.25:compile
< 
---
> [INFO]    \- org.slf4j:slf4j-api:jar:1.7.32:compile

Nar deps diff

(Using https://gist.github.com/nicoloboschi/d3e9a2de3175abc3fd7c13e9dd10187b)

Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: guava-30.1-jre.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: guava-31.0.1-jre.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: kafka-connect-avro-converter-shaded-2.10.2.4.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: kafka-connect-avro-converter-shaded-2.10.2.5.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: netty-buffer-4.1.72.Final.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: netty-buffer-4.1.77.Final.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: netty-common-4.1.72.Final.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: netty-common-4.1.77.Final.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: pulsar-client-admin-api-2.10.2.4.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: pulsar-client-admin-api-2.10.2.5.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: pulsar-client-api-2.10.2.4.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: pulsar-client-api-2.10.2.5.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: pulsar-client-original-2.10.2.4.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: pulsar-functions-api-2.10.2.4.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: pulsar-functions-api-2.10.2.5.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: pulsar-io-core-2.10.2.4.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: pulsar-io-core-2.10.2.5.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: pulsar-io-kafka-connect-adaptor-2.10.2.4.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: pulsar-io-kafka-connect-adaptor-2.10.2.5.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: slf4j-api-1.7.25.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: slf4j-api-1.7.32.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: snakeyaml-1.31.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: snakeyaml-1.32.jar
Only in pulsar-snowflake-connector-0.1.13-alpha.nar/META-INF/bundled-dependencies/: snowflake-kafka-connector-shaded-0.1-reduce-size.jar
Only in pulsar-snowflake-connector-0.1.13-SNAPSHOT.nar/META-INF/bundled-dependencies/: snowflake-kafka-connector-shaded-0.1.13-SNAPSHOT.jar

@nicoloboschi nicoloboschi merged commit 060bd9b into master Nov 23, 2022
@nicoloboschi nicoloboschi deleted the use-import branch May 15, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants