Skip to content
This repository has been archived by the owner on Jan 22, 2020. It is now read-only.

Support usage of MyBinder.org - fixes #2, #3 #4

Merged
merged 3 commits into from
Jul 11, 2019

Conversation

consideRatio
Copy link
Contributor

@consideRatio consideRatio commented Jun 26, 2019

🎉 ❤️ I'm excited about what you have done and very happy that you have shared your code on GitHub! I'm keen on learning more about data visualization and your code is good inspiration. I also love the use of imagemagick to generate gifs!

Background

This PR is a consequence of @salgo60 who made me spot this tweet in my Twitter feed. Very happy and curious about what I saw I wanted to run the code myself.

MyBinder.org can help anyone run code from git repositories by constructing a custom Dockerfile that pre-installes a good foundation and adds everything needed to run the source code found in a git repository. But, mybinder.org, which is really a BinderHub, which in turn relies on repo2docker, did not yet support installing Python dependencies from Pipfile at this time.

So, I set out to make a contribution to resolve that (repo2docker#649). With the help of @betatim to review and get it good enough for merge this support has now propagated to mybinder.org.

This makes this repo, with the small adjustment of adding a apt.txt file in it listing the imagemagick dependency runnable with a single click of a button.

MyBinder.org buttons

This is a button to run the code in my fork (this PR):
Binder

This is a button to run the code in this repo's master branch:
Binder

What this PR does

So it is quite a mash of stuff, sorry for not making them separate PRs, I wanted to save some of my time. You can review the commits one by one to better understand what I've done if it seems messy from looking at the files changed section of this PR.

Finally

@lapidus @miroli I'm hoping to be able to meet you in Stockholm tomorrow if that is possible!

Lots of appreciation for the work you have done!
/ Erik Sundell

- Added a mybinder.org badge
- Wrote more explicit local installation instructions
- Simplified the styling advice based on fix for datastory-org#2
@lapidus
Copy link
Contributor

lapidus commented Jun 27, 2019

This is really nice @consideRatio. Thank you so much for the contribution. @miroli and I will assess the PR and add any comments. See you in Sthlm!

@miroli
Copy link
Collaborator

miroli commented Jun 28, 2019

Thanks for the PR @consideRatio. Great stuff! This looks ready to be merged. Any additional comments @lapidus?

@consideRatio
Copy link
Contributor Author

Your very welcome @miroli, thank you for all the work you do with datastory. It was inspiring to meet you @lapidus @miroli!

@consideRatio
Copy link
Contributor Author

Off topic to the PR

I wanted to ping the organizers of OpenHack Stockholm in November, as I think weekly-chart showcase excellent Jupyter notebooks and some realistic situations where data is consumed from external sources. OpenHack, meet Datastory btw ;)

Monika and @NikeH, this repo contains Jupyter notebooks with code etc to generate the graphs (sometimes turned into gif animations), that are presented on https://datastory.org/sv/veckans-graf. This PR mostly added a button in markdown to the README.md of this repo. The button acting as a web link to mybinder.org with some passed details, allows this code to be runnable in a autogenerated docker container hosted on the cloud, using the free service without a need to login, meant to help make science reproducible etc.

Try running the code yourself that generated the charts at datastory.org:
Binder


GIF showing datastory.org's weekly chart:
datajournalistik-datastory

@lapidus lapidus merged commit 5e4a51a into datastory-org:master Jul 11, 2019
@lapidus
Copy link
Contributor

lapidus commented Jul 11, 2019

Thank you @consideRatio. Very nice to meet you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lacking support for mybinder.org plt.style.use('datastory') fails
3 participants