Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dealing with #28 #29

Merged
merged 1 commit into from
Sep 28, 2018
Merged

Dealing with #28 #29

merged 1 commit into from
Sep 28, 2018

Conversation

agbeltran
Copy link
Member

No description provided.

@agbeltran
Copy link
Member Author

@kifeonu please see #24 and this PR for its implementation
I had first thought to add a generic array with "dates" but then decided that a specific date will be clearer for this case. Do you think we need to record other dates?

@kifeonu
Copy link

kifeonu commented Sep 26, 2018

@agbeltran This is fine. The only date in the AGR phenotype and disease JSONs is dateAssigned

@agbeltran agbeltran merged commit 41b0dd2 into master Sep 28, 2018
@agbeltran agbeltran deleted the relationEvidence-extension branch September 28, 2018 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agbeltran @kifeonu