Added phovea_importer to tdp_core #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puehringer
force-pushed
the
mp/phovea_importer_to_visyn
branch
from
7b758bd
to
55dd03f
Compare
thinkh
approved these changes
Nov 30, 2021
There was a problem hiding this comment.
Thanks for moving the repo here. I've adapted tdp_uploaded_data and created PR https://github.com/datavisyn/tdp_uploaded_data/pull/107.
Everything works fine in my tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added phovea_importer to tdp_core.
Breaking changes:
Both
phovea_importerandtdp_corealready exportValueTypeUtils. Therefore, thephovea_importerValueTypeUtilsis now calledPHOVEA_IMPORTER_ValueTypeUtilsuntil a rename is done.