Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: remove lineupjs as it is coming from visyn_core #854

Merged
merged 2 commits into from
Aug 9, 2023
Merged

deps: remove lineupjs as it is coming from visyn_core #854

merged 2 commits into from
Aug 9, 2023

Conversation

puehringer
Copy link
Contributor

@puehringer puehringer commented Aug 9, 2023 •
edited
Loading

Developer Checklist (Definition of Done)

Issue

  • All acceptance criteria from the issue are met
  • Tested in latest Chrome/Firefox

UI/UX/Vis

  • Requires UI/UX/Vis review
    • Reviewer(s) are notified (tag assignees)
    • Review has occurred (link to notes)
    • Feedback is included in this PR
    • Reviewer(s) approve of concept and design

Code

  • Branch is up-to-date with the branch to be merged with, i.e., develop
  • Code is cleaned up and formatted
  • Unit tests are written (frontend/backend if applicable)
  • Integration tests are written (if applicable)

PR

  • Descriptive title for this pull request is provided (will be used for release notes later)
  • Reviewer and assignees are defined
  • Add type label (e.g., bug, feature) to this pull request
  • Add release label (e.g., release: minor) to this PR following semver
  • The PR is connected to the corresponding issue (via Closes #...)
  • Summary of changes is written

Summary of changes

  • Removes lineupjs as it is coming from visyn_core. Also, the wrong version was pinned, thus it installed lineupjs twice.

Screenshots

Additional notes for the reviewer(s)

Thanks for creating this pull request 🤗

@puehringer puehringer requested a review from a team as a code owner August 9, 2023 06:39
@puehringer puehringer added release: patch PR merge results in a new patch version dependencies Pull requests that update a dependency file labels Aug 9, 2023
@puehringer puehringer requested a review from thinkh August 9, 2023 06:39
thinkh
thinkh previously approved these changes Aug 9, 2023
View reviewed changes
@thinkh thinkh changed the base branch from main to develop August 9, 2023 06:44
@thinkh thinkh dismissed their stale review August 9, 2023 06:44

The base branch was changed.

thinkh
thinkh approved these changes Aug 9, 2023
View reviewed changes
Copy link
Member

@thinkh thinkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks.

@thinkh thinkh merged commit 4d24321 into develop Aug 9, 2023
@thinkh thinkh deleted the mp/remove_lineup branch August 9, 2023 06:49
@thinkh thinkh mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkh thinkh thinkh approved these changes

Assignees

@thinkh thinkh

Labels
dependencies Pull requests that update a dependency file release: patch PR merge results in a new patch version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@puehringer @thinkh