feat: validate sequence numbers for file connections #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| io::Error::new( | ||
| match Response::try_from(recv) { | ||
| Ok(response) => { | ||
| if response.seq() == self.seq { |
There was a problem hiding this comment.
The only downside I see with this is that we "no longer" (not that I think anyone was ever using it, but you know) support reception of messages out-of-order.
I don't, however, think we need to worry about that now, just a comment for in the future. It should be easy to fix at any rate :)
datdenkikniet
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed one of our agents was seemingly sending bogus data that didn't match ipmitool. It was fixed by a restart. Looking at the captured data, I can see that the raw_reading value that we were expecting to see from the obviously bogus sensor was being captured by a different sensor up until we restarted our agent.
I can't say for certain that the sequence number is the issue but it seems plausible.