Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qsv diff -s <arg> if both files use the same delimiter #2447

Closed
ondohotola opened this issue Jan 16, 2025 · 1 comment · Fixed by #2464
Closed

qsv diff -s <arg> if both files use the same delimiter #2447

ondohotola opened this issue Jan 16, 2025 · 1 comment · Fixed by #2464
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.

Comments

@ondohotola
Copy link

I had to do a diff on two semicolon separated files, and had to enter --delimiter-left <arg> and --delimiter-right <arg>.

If both have the same delimiter, should one then not perhaps also have a -d<arg>?
@jqnatividad jqnatividad added the enhancement New feature or request. Once marked with this label, its in the backlog. label Jan 18, 2025
@jqnatividad
Copy link
Collaborator

jqnatividad commented Jan 18, 2025 •
edited
Loading

Once @janriemer fixes #2443, I can certainly add this "convenience" option as an enhancement.

jqnatividad added a commit that referenced this issue Jan 21, 2025
@jqnatividad
feat: diff add --delimiter option
7c1967f 
as per #2447

Also inlined `write_diff_byte_record` which is in a hot loop
@jqnatividad jqnatividad mentioned this issue Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request. Once marked with this label, its in the backlog.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: diff add --delimiter "convenience" option dathere/qsv
2 participants
@jqnatividad @ondohotola