Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

describegpt: add base_url, model, ollama, & timeout to prompt file #1859

Merged
merged 1 commit into from
Jun 4, 2024

Conversation

rzmk
Copy link
Collaborator

@rzmk rzmk commented Jun 3, 2024

Adds base_url, model, ollama, and timeout to the prompt file for describegpt along with updating checks for any of those prompt file values are used and docs.

Comment on lines +236 to +243
if arg_is_some("--ollama") {
let models = response_json["models"].as_array().unwrap();
for model in models {
if model["name"].as_str().unwrap() == given_model {
return Ok(true);
}
}
} else if prompt_file.ollama {

Check warning

Code scanning / clippy

this if has identical blocks Warning

this if has identical blocks
@jqnatividad jqnatividad merged commit 5756de0 into master Jun 4, 2024
14 of 15 checks passed
@jqnatividad
Copy link
Collaborator

Thanks @rzmk !

@rzmk rzmk deleted the describegpt/updates branch June 21, 2024 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants