Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

roll up of all open PRs, plus 2 fixes #14

Merged
merged 16 commits into from
May 6, 2019
Merged

roll up of all open PRs, plus 2 fixes #14

merged 16 commits into from
May 6, 2019

Conversation

maphew
Copy link
Contributor

@maphew maphew commented Feb 7, 2019

This pull request incorporates PR #8, #9, #10, #13 and closes #11 and #12

  • fix setupext namespace collision
  • typo in readme usage notes for --eggs
  • shield.io instead pyp.in for badges
  • also catch and remove .eggs folder
  • Early exit on Windows because distutils tries to something with RPM

ionelmc and others added 13 commits November 17, 2015 00:58
@ionelmc
Rename package and remove the namespace stuff.
553b74d
@kotfu
Fix typo in command line options
ed58e6c
@maphew
must be --eggs else "error: option --egg not a unique prefix"
d6e4b07 
```
> python setup.py clean --egg
Creating entry_points for [OS name - system]: nt - Windows
c:\apps\miniconda3\envs\leo-dev\lib\site-packages\setuptools\dist.py:351: UserWarning: Normalizing '5.8.1-b1-dev1038' to '5.8.1b1.dev1038'
  normalized_version,
usage: setup.py [global_opts] cmd1 [cmd1_opts] [cmd2 [cmd2_opts] ...]
   or: setup.py --help [cmd1 cmd2 ...]
   or: setup.py --help-commands
   or: setup.py cmd --help

error: option --egg not a unique prefix
```
@maphew @ionelmc
to complete upstream PR dave-shawley#8
b00781d
@maphew
also catch .eggs plural (dave-shawley#11)
e73f083
@maphew
Merge branch 'patch-1'
874058c
@maphew
Merge pull request #2 from ionelmc/master
86ce8c6 
catch my fork up with ionel's
@maphew
WIP: identify where RPM exit occurs (dave-shawley#12)
3dca206
@maphew
WIP: don't exit on error, but we don't deal with it either!
7f65c8d
@maphew
WIP: don't exit on error, but we don't deal with it either!
b725529
@maphew
WIP: display the actual buried distutils traceback
57b53d6
@maphew
keep going *only* if RPM-on-NT err (dave-shawley#12)
42508a6 
this is as solid and concise as I know how to do.
@maphew
Merge pull request #3 from kotfu/master
f8d47d2 
Fix typo in command line options
@maphew
Copy link
Contributor Author

maphew commented Feb 7, 2019

Eeep. Travis failed because I used the newer py3.6 f'...' print() syntax instead of '...'.format(). I'll fix that.

@maphew maphew mentioned this pull request Feb 8, 2019
Open
@maphew
Copy link
Contributor Author

maphew commented May 2, 2019

@dave-shawley I'm happy to help with maintenance of this module. (It would be good to get a current version on Pypi.)

@dave-shawley
Copy link
Owner

@maphew I have no clue how I missed this activity. It must have gotten lost in the inbox altogether. I did notice the direct mentions from you and @cmarquardt this morning. Sounds like I need to check my GitHub notification settings. I am very sorry about letting this languish. It never caught on at work so I haven't been using it. I'll review the rolled up PR and see what is left afterwards.

To @maphew , @cmarquardt, @ionelmc, @kotfu and anyone else that I've ignored, I'm sorry about that. I really do appreciate the assistance.

@maphew
Copy link
Contributor Author

maphew commented May 3, 2019 via email

@dave-shawley dave-shawley merged commit c03b226 into dave-shawley:master May 6, 2019
@maphew
Copy link
Contributor Author

maphew commented Jul 15, 2019

@dave-shawley now that the PR has been merged, it's safe for me to delete my fork right? I don't need it anymore but I don't want to mess anyone else up.

@maphew maphew mentioned this pull request Jul 15, 2019
Closed
@dave-shawley
Copy link
Owner

@dave-shawley now that the PR has been merged, it's safe for me to delete my fork right? I don't need it anymore but I don't want to mess anyone else up.

@maphew yup. You should be good. Lemme know if you run into any other issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean --egg misses .eggs (plural)
4 participants
@maphew @dave-shawley @ionelmc @kotfu