-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Go 1.8 TLS tracing support & refactor timing code #128
base: master
Are you sure you want to change the base?
Conversation
@davecheney: The failing test does also fail on master. |
@davecheney some tests are still failing, even after the fix. Apparently, httpbin has some connectivity issue. Please just relaunch the test. |
.travis.yml
Outdated
- 1.9.x | ||
- "1.8.x" | ||
- "1.9.x" | ||
- "1.10.x" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please change this to
- 1.10.x
exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with small change.
Done, tests are still randomly failing though. |
I've merged a few of the outstanding commits, can you please rebase and we'll see what's left. |
I think i've fixed the failing tests, please try again. |
To have accurate measurement of TLS and support skipped steps (DNS, TCP and TLS reuse), the timing code has been refactored to use Go 1.8 support for TLS tracing as well as a more descriptive variable namings for steps time. This commit removes support for Go versions lower than 1.8.
httpbin is still failing from travis. |
@davecheney what about removing the httpbin tests? Could be replaced by a mock server. |
@davecheney any chance to merge this? |
@davecheney any chance to have a look at this? Thanks! |
To have accurate measurement of TLS and support skipped steps (DNS, TCP
and TLS reuse), the timing code has been refactored to use Go 1.8
support for TLS tracing as well as a more descriptive variable namings
for steps time.
This commit removes support for Go versions lower than 1.8.