Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(readme): add Go 1.17+ install command #160

Merged
merged 3 commits into from
Aug 27, 2021

Conversation

nikoksr
Copy link
Contributor

@nikoksr nikoksr commented Aug 27, 2021

Summary

Hi @davecheney, this PR is to bring the readme up to date with Go 1.17 and only brings a small addition to the installation instructions.

Proposed Changes

  • Add new install command for Go versions 1.17+ to readme

Reason

Starting in Go 1.17, installing executables with go get is deprecated. go install may be used instead.

screenshot-27082021-154923

Read here for more info about this.

Copy link
Owner

@davecheney davecheney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this. Let’s just change the instructions to the 1.17 form and leave it at that, 1.16 has less than six months to live at this point.

@nikoksr nikoksr requested a review from davecheney August 27, 2021 21:03
@davecheney
Copy link
Owner

TYVM

@davecheney davecheney merged commit 74b2de5 into davecheney:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants