Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

regression in path-params rule, complains about missing path params that are valid #390

Closed
TristanSpeakEasy opened this issue Dec 5, 2023 · 2 comments
Closed

regression in path-params rule, complains about missing path params that are valid #390

TristanSpeakEasy opened this issue Dec 5, 2023 · 2 comments
Labels
libopenapi a bug in libopenapi needs investigation

Comments

@TristanSpeakEasy
Copy link
Contributor

I am seeing these errors showing up in the latest vacuum release

"validation error: [line 35] path-params - `POST` must define parameter `org` as expected by path `/test2/org/{org}/team/{team}` | $.paths['/test2/org/{org}/team/{team}'].post",
"validation error: [line 35] path-params - `POST` must define parameter `team` as expected by path `/test2/org/{org}/team/{team}` | $.paths['/test2/org/{org}/team/{team}'].post",

that are new regressions, the attached specs show the issue and are definitely valid.

references.zip
@TristanSpeakEasy
Copy link
Contributor Author

@daveshanley any luck figuring out this one?

@LasneF LasneF mentioned this issue Feb 6, 2024
Closed
daveshanley added a commit to pb33f/libopenapi that referenced this issue Feb 6, 2024
@daveshanley
Addressed daveshanley/vacuum#390
d53499f 
And daveshanley/vacuum#446

Signed-off-by: quobix <dave@quobix.com>
@daveshanley daveshanley mentioned this issue Feb 6, 2024
Merged
daveshanley added a commit to pb33f/libopenapi that referenced this issue Feb 7, 2024
@daveshanley
Addressed daveshanley/vacuum#390
103f2df 
And daveshanley/vacuum#446

Signed-off-by: quobix <dave@quobix.com>
@daveshanley daveshanley mentioned this issue Feb 7, 2024
Merged
@daveshanley
Copy link
Owner

This has been resolved in v0.9.0 It was fixed in libopenapi and a test was added to ensure it would not return.

https://github.com/pb33f/libopenapi/blob/main/index/spec_index_test.go#L1618

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
libopenapi a bug in libopenapi needs investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daveshanley @TristanSpeakEasy