Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added noRequestBody function to check that HTTP GET and DELETE methods do not contain a requestBody #588

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

lobocv
Copy link

@lobocv lobocv commented Nov 25, 2024

Requested from here: #582

Formats: model.OAS3AllFormat,
Description: "HTTP GET and DELETE should not accept request bodies",
Given: "$",
Resolved: false,
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daveshanley I don't know what Resolved means. Should it be true or false here?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved means that the $ref values have all been stitched together by the resolver in libopenapi

This is used for rules that assume everything is resolved and inlined. It only makes a difference if the logic in your rule / function is recursive - if so, it means that any circular references could create an infinite loop.

@lobocv
Copy link
Author

lobocv commented Dec 13, 2024

@daveshanley bump :)

@daveshanley
Copy link
Owner

@daveshanley bump :)

Will get to this ASAP, apologies for my slowness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants