-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ADD: Readarr - an ebook collection manager for Usenet and BitTorrent users #580
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few questions and changes required on this PR.
roles/readarr/tasks/main.yml
Outdated
pull: true | ||
volumes: | ||
- "{{ readarr_data_directory }}/config:/config" | ||
- "{{ books_root }}:/books" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please abstract this the same as readarr_downloads_root
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
roles/readarr/defaults/main.yml
Outdated
readarr_download_directory: "{{ downloads_root }}" | ||
|
||
# uid / gid | ||
readarr_user_id: "998" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where did this uid / gid come from?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. 998 is my ansible-nas user. I'll have to go test and figure out why I choose that long ago. Probably should be 1000 if 0 doesn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to use root like all the other *arr linuxserver app defaults
roles/readarr/tasks/main.yml
Outdated
pull: true | ||
volumes: | ||
- "{{ readarr_data_directory }}/config:/config:rw" | ||
- "{{ books_root }}:/books:rw" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to use the new variable you created - I wouldn't expect to see books_root
here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Done. (I swear I did this yesterday!)
What this PR does / why we need it:
Adds Readarr - an ebook collection manager for Usenet and BitTorrent users
...because we can't be missing any of the arr programs now can we?!
Which issue (if any) this PR fixes:
Fixes #
Any other useful info: