-
-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Authelia #632
base: main
Are you sure you want to change the base?
Add Authelia #632
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! With the minimal description in the PR I'm struggling to piece together how this would work, or what the PR provides.
Few thoughts:
- There are numerous hard-coded assumptions (ie whitelisted network ranges)
- Why is there an additional docker network created?
- Why are some of the containers named "example"?
- I don't like the "edit the configuration.yml" instruction - it's a big ansible-nas anti-pattern. As soon as people do that, it creates merge issues in the future. Also, the file is a template.
Currently, I'm not sure how we can proceed with this in a way that it's useful for people - perhaps if you can explain the thinking it'd help?
Yeeees, I was going alphebetically, and this difficult container was one of the first on the list ;)
To be able to truly integrate Authelia using traefik labels, the whole playbook would probably need to be reworked, Authelia set up as some high-level condition, etc. I'm not willing to go there now, so feel free to close this. |
Hi, I agree that Authelia should be part of this project, I\ve had it running now since february last year.
I also set it up with different levels of security so that my router, codeserver and a few other apps needs multiple factors for login and other only username and password. |
What this PR does / why we need it:
Adds Authelia
Which issue (if any) this PR fixes:
None
Fixes #
None
Any other useful info: