138 version switch #143
Closed
138 version switch #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the first commit looks good. The second one would be good, if I didn't have a similar version of this on a branch. I've been workingn on some new features on a branch since I wasn't sure if they would pan out. They are and I'm gonna release an RC hopefully today. I'll notify you here when I do |
|
Cool - thanks for taking the time to review my work. I look forward to seeing the RC. This is a fantastic tool. |
|
Fixed in 2.6.0 https://github.com/davetron5000/gli/wiki/Changelog thanks for the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to resolve pull request #138 - "--version option invokes help command".
Two simple changes:
Changed a few cucumber features to reflect the changes. Added a new scenario to test the new feature. All pass, as do tests. All changes are in a "138-version-switch" branch, which should merge into the gli-2 branch as of this date.