Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conflict with set 'li' and 'active-class' #1

Closed
ZoIcHi opened this issue Jul 5, 2019 · 2 comments
Closed

Conflict with set 'li' and 'active-class' #1

ZoIcHi opened this issue Jul 5, 2019 · 2 comments
Labels

Comments

@ZoIcHi
Copy link

ZoIcHi commented Jul 5, 2019

hi, first of all congratulations for the excellent script.

unfortunately I noticed a bug ...

if in boostrapmenu.php set the parameter 'li', with a class, the class 'active-class' is not applied.

I think the problem is that there is no correct merge between,

'li', array('class'=>'nav-item') in BootstrapMenu.php
and
$this->set('active-class', array('class' => $this->activeClass)); in QuickMenu.php row #63

Regards

@davicotico davicotico added the bug label Apr 22, 2020
@davicotico
Copy link
Owner

@ZoIcHi thanks for report the bug.
My apologies for the late response.
You are right, there is a conflict and the script is generating a duplicate class attribute instead of adding the class:
<li class="test-classitem" class="active">...</li>
I am gonna to fix the bug and then release the version 1.0.1
Thanks again.

@davicotico
Copy link
Owner

PHP QuickMenu 1.0.1 is available.
https://github.com/davicotico/PHP-Quick-Menu/releases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants