Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codegen: Fixed URL resolution and added most types #4

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Codegen: Fixed URL resolution and added most types #4

merged 2 commits into from
Jun 27, 2023

Conversation

gBasil
Copy link
Contributor

@gBasil gBasil commented Jun 26, 2023

@gBasil
Copy link
Contributor Author

gBasil commented Jun 26, 2023

I also had to change "module": "./dist/client/index.mjs", to "module": "./dist/client/index.js", in package.json, but I'm not sure if this is the best solution, given you have .mjs in there, so it's not in this PR.

@david-plugge
Copy link
Owner

I also had to change "module": "./dist/client/index.mjs", to "module": "./dist/client/index.js", in package.json, but I'm not sure if this is the best solution, given you have .mjs in there, so it's not in this PR.

Your change is correct, i added "type": "module" but forgot to update the entrypoints.

@david-plugge david-plugge merged commit 5564539 into david-plugge:next Jun 27, 2023
@david-plugge
Copy link
Owner

Thank you!

@david-plugge
Copy link
Owner

0.0.3-next.3 now includes all types and even supports modifiers for select, relation and file columns (according to https://pocketbase.io/docs/collections/#overview).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants