-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deploy shuts off maintenance mode #16
Comments
@giacmir Good call! I'll plan on adding this to a patch release soon… |
@giacmir Wanted to let you know… I was going to try and get this done before I go on holiday for 3 weeks, but time did not allow for it. I'm getting married this Saturday and won't back in the saddle with work or any Magento related stuff until September. :) So it might be a while longer before I can personally get to adding this to the gem. |
@davidalger I'm very happy to wait for such a cheerful cause and best wishes for your family life! |
…lly enabled prior to deployment (issue #16)
@giacmir I'm happy to report that after this long amount of time (sorry about the wait) I have finally made the time to implement this. I did the implementation in the same maintenance mode check routine used to accomplish zero-down deployments. See the above commit for details. I'll be including this in the next release when I push it out (I expect will be in the next few days) |
This has been published as part of v0.8.1. Thanks again for the suggestion! |
If a deploy is made when magento is in maintenance mode then is set back online. It would be useful to detect the current application maintenance status and disable maintenance mode only if it was already disabled at the beginning of the deploy process.
The text was updated successfully, but these errors were encountered: