Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy shuts off maintenance mode #16

Closed
giacmir opened this issue Jul 28, 2016 · 5 comments
Closed

Deploy shuts off maintenance mode #16

giacmir opened this issue Jul 28, 2016 · 5 comments
Assignees

Comments

@giacmir
Copy link
Contributor

giacmir commented Jul 28, 2016

If a deploy is made when magento is in maintenance mode then is set back online. It would be useful to detect the current application maintenance status and disable maintenance mode only if it was already disabled at the beginning of the deploy process.

@davidalger
Copy link
Owner

@giacmir Good call! I'll plan on adding this to a patch release soon…

@davidalger
Copy link
Owner

@giacmir Wanted to let you know… I was going to try and get this done before I go on holiday for 3 weeks, but time did not allow for it. I'm getting married this Saturday and won't back in the saddle with work or any Magento related stuff until September. :) So it might be a while longer before I can personally get to adding this to the gem.

@giacmir
Copy link
Contributor Author

giacmir commented Aug 10, 2016

@davidalger I'm very happy to wait for such a cheerful cause and best wishes for your family life!

davidalger added a commit that referenced this issue Jun 21, 2017
…grade`

This is being done to support zero-downtime deploys on #34 as well as plan for tracking of maintenance mode state so that per #16 it will only be disabled if it was first enabled during the built-in setup:db:upgrade task.
davidalger added a commit that referenced this issue May 30, 2018
@davidalger
Copy link
Owner

@giacmir I'm happy to report that after this long amount of time (sorry about the wait) I have finally made the time to implement this. I did the implementation in the same maintenance mode check routine used to accomplish zero-down deployments. See the above commit for details. I'll be including this in the next release when I push it out (I expect will be in the next few days)

@davidalger davidalger self-assigned this May 30, 2018
@davidalger
Copy link
Owner

This has been published as part of v0.8.1.

Thanks again for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants