Some setup:di:compile errors not reported

[erikhansen]

This issue is a similar problem to the one reported in #25. It is also somewhat related to #35.

Here is an example screenshot demonstrating the problem:

I'm using Magento EE 2.1.2. Errors generated during setup:di:compile are not being reported when deploying. The errors are essentially being ignored and the deployment continues as if nothing happened.

I think the problem is that we assumed that Magento 2.1.x fixed the issue where setup:di:compile and setup:static-content:deploy were not returning non-zero exit codes upon failure, but this is not always the case. While the magento/magento2#3189 PR did fix the return code issue in many situations, it looks there are certain "soft" errors that don't result in error codes: https://github.com/magento/magento2/blob/1ade3b769a937f19682bbbe4e51b6c956147952f/setup/src/Magento/Setup/Module/Di/Compiler/Log/Writer/Console.php#L72

[davidalger]

Released in 0.5.6.