Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

first commit delong_test #22

Merged
merged 6 commits into from
Sep 17, 2021
Merged

Conversation

gpucce
Copy link
Contributor

@gpucce gpucce commented Sep 8, 2021

Here is the starting pull request, indeed the way you implement roc does not really matter since one needs to compute from tar, nontar anyway, I will add documentation to the functions, though I don't really know what to write. I also add a link to an explanation of what the test is supposed to do.

If you think this is not useful or anything just delete it or if it needs strong changes tell me I am happy to try to do it.

@davidavdav
Copy link
Owner

OK, thanks, perhaps add a couple of test cases, which are useful if we change the coding style a little here and there, to make sure we're still doing the right thing

@gpucce
Copy link
Contributor Author

gpucce commented Sep 10, 2021

Sure I will, I started very enthusiastic but then work kicked in xD in the next days I'll add the tests.

@gpucce
Copy link
Contributor Author

gpucce commented Sep 12, 2021

Tests added!! Let me know if they are enough.

@gpucce gpucce marked this pull request as ready for review September 15, 2021 22:15
@davidavdav
Copy link
Owner

In github I see a few files that end without a newline, could you add these please?

@davidavdav davidavdav merged commit 5421f78 into davidavdav:main Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants